Include location type

  1.  
    1. sprocketonline Top Contributor Freebase Experts
      Jun 27, 2009
      sprocketonline says:

      Structure includes the location type, but I noticed that building doesn't.  Could location be an included type for building?

      2. brendan Metaweb Staff
        Jun 30, 2009
        brendan says:

        sorry for the late reply, i missed this post... building includes structure, so if someone types a topic as a building (through the ui) it will get typed as a structure and therefore as a location. "inclusion" is very loose (as intended). If someone is absolutely certain that a structure (or a building) is *not* a location the system allows them to assert that. Furthermore, if you're not using the ui, the 3rd party/acre app needs to handle the inclusion logic on it's own, it's not at the mql layer.  Sorry, if you already knew all this stuff, I say all that just as a preamble to my point which is: I consider putting the inclusion of location on the "base" type (structure) as proper and, to borrow a db term, "normalized". I think it works in the vast majority of cases and has the nice property of being spare/simple. Am I making any sense?

      3. sprocketonline Top Contributor Freebase Experts
        Jun 30, 2009
        sprocketonline says:

        Perfect sense, thanks Brendan

        I'd typed something (forget what now) as a building the other day, and the location type didn't automatically appear on the topic but the structure type did.

        So I poked around in the building schema and noticed that location wasn't included, so thought that was the problem. 

        Is the location added later by the gardening bot, or was it just an anomaly/bug that the location type wasn't added at the time?

      4. brendan Metaweb Staff
        Jun 30, 2009
        brendan says:

        hmm. I guess I was mistaken. Though I think the freebase.com ui, *should* respect the "chain" of inclusions, it does not.  I just typed something on sandbox as a "building" and I expected it to be typed structure (which it was) but I also expected that the included types for structure (like location) would be added as well.  location was not added.

        Thinking about this a bit more, there are probably cases where "recursive inclusion" is not desirable.  I can't really think of any off hand.

        Well, in short, I think I should just do what you asked because the qa guys just informed me that this has always worked this way.  And maybe I should open a feature request to suggest that recursive inclusion is desirable. 

      5. skud Metaweb Staff
        Jun 30, 2009
        skud says:

        I think the tree-walking happens in the schema editor at the time when you include the type.

      6. pak21 Freebase Experts
        Jun 30, 2009
        pak21 says:

        I raised this on the dev list a while back, and the response was very much that this is intentional and desired.

        http://lists.freebase.com/pipermail/developers/2009-May/002901.html

      7. brendan Metaweb Staff
        Jul 1, 2009
        brendan says:

        Thanks! I've opened a bug to track this work https://bugs.freebase.com/browse/DA-841

    Discussion is posted in:

    Think this discussion also relates to something else? Cross-post it by adding a new discussion area:

Search Discussions

Related Discussions